Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using 'gmsaas doctor' command #4676

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Start using 'gmsaas doctor' command #4676

merged 3 commits into from
Dec 29, 2024

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Dec 26, 2024 •
edited
Loading

Description

In this pull request, I have closed the loop of replacing the decommissioned gmsaas auth whoami command with the gmsaas doctor command.

cc @lilinor

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@d4vidi d4vidi self-assigned this Dec 26, 2024
@d4vidi d4vidi requested a review from noomorph as a code owner December 26, 2024 13:13
@d4vidi d4vidi requested a review from asafkorem December 26, 2024 14:16
@asafkorem asafkorem removed the request for review from noomorph December 26, 2024 14:17
asafkorem
asafkorem requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor change

detox/src/devices/allocation/drivers/android/genycloud/exec/GenyCloudExec.test.js Outdated Show resolved Hide resolved
@d4vidi d4vidi changed the title Starting using 'doctor' command Starting using 'gmsaas doctor' command Dec 28, 2024
@d4vidi d4vidi enabled auto-merge (squash) December 29, 2024 16:30
@d4vidi d4vidi merged commit 2b4df68 into master Dec 29, 2024
3 checks passed
@d4vidi d4vidi deleted the gmsaas-doctor branch December 29, 2024 17:23
@lilinor
Copy link
Contributor

lilinor commented Dec 31, 2024

Great to see that it is now implemented ! 🙌

@d4vidi d4vidi changed the title Starting using 'gmsaas doctor' command Start using 'gmsaas doctor' command Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafkorem asafkorem asafkorem approved these changes

Assignees

@d4vidi d4vidi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gmsaas doctor
3 participants
@d4vidi @lilinor @asafkorem